Issue 7566049: Add content-security-policy directive to print-preview pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7566049: Add content-security-policy directive to print-preview pages. (Closed)

Created:
9 years, 4 months ago by Tom Sepez

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade, abarth-chromium

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add content-security-policy directive to print-preview pages. Since print-preview uses an object tag, relax the object-src restriction in the content_security_policy.html file. Also fix typo in print_preview.html where the object tag has a src="", not a data="" attribute. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95850

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -158 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/content_security_policy.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.html	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_data_source.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_data_source.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_data_source.cc	View	2 chunks	+84 lines, -141 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Tested manually with --enable-print-preview. Was able to print page to printer.

9 years, 4 months ago (2011-08-05 00:24:25 UTC) #1

lgtm

Expand Messages | Collapse Messages