Sync Promo: Remember promo expanded state

Sync Promo: Remember promo expanded state

With this change we save the expanded/collapsed state of the sync promo to preferences.

BUG=
TEST=Collapsed the promo and verified that it stayed collapsed on the next launch.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95478

[sail, 2011-08-04 02:16:06]

erg: profile stuff
jhawkins: everything else

[James Hawkins, 2011-08-04 02:57:37]

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
File chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc (right):

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc:86: if
(web_ui_->GetProfile()->GetPrefs()->GetBoolean(
Combine this if logic with the logic from the previous if.

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc:89:
SaveExpandedPreference(true);
Is it possible to move the call to SaveExpandedPreference(true) to
OpenSyncSetup()?   Same for false and CloseSyncSetup().

[Elliot Glaysher, 2011-08-04 17:22:47]

profile lgtm

[sail, 2011-08-04 17:33:01]

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
File chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc (right):

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc:86: if
(web_ui_->GetProfile()->GetPrefs()->GetBoolean(
On 2011/08/04 02:57:37, James Hawkins wrote:
> Combine this if logic with the logic from the previous if.

Done.

http://codereview.chromium.org/7566026/diff/1/chrome/browser/ui/webui/ntp/new...
chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc:89:
SaveExpandedPreference(true);
On 2011/08/04 02:57:37, James Hawkins wrote:
> Is it possible to move the call to SaveExpandedPreference(true) to
> OpenSyncSetup()?   Same for false and CloseSyncSetup().

If the promo closes because the user completes the sync setup we don't want to
change the preference. This way, if they sign out of sync, we'll re-open the
promo.

For the same reason, I'd like to keep the SaveExapndedPreference(true) call out
of OpenSyncSetup().

[James Hawkins, 2011-08-04 17:35:40]

LGTM

[commit-bot: I haz the power, 2011-08-04 20:29:22]

Change committed as 95478