Issue 7566023: Enabled BubbleWindowViews class for the Pure Views case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7566023: Enabled BubbleWindowViews class for the Pure Views case. (Closed)

Created:
9 years, 4 months ago by Emmanuel Saint-loubert-Bié

Modified:
9 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Consolidated factories to make it clearer that the goal is to have only one BubbleWindow class in the end. Enabled BubbleWindowViews class for the Pure Views case. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95424

Patch Set 1 #

Patch Set 2 : ' #

Patch Set 3 : Merged #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -25 lines)			Patch
M	chrome/browser/chromeos/frame/bubble_window.cc	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/frame/bubble_window_views.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/frame/bubble_window_views.cc	View		1 chunk	+8 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Hi Xiyuan I have consolidated both factories and added the background color we discussed yesterday. ...

9 years, 4 months ago (2011-08-04 00:29:13 UTC) #1

LGTM

Expand Messages | Collapse Messages