Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 7566018: chromeos: Update volume key behavior. (Closed)

Created:
9 years, 4 months ago by Daniel Erat
Modified:
9 years, 4 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, derat+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Update volume key behavior. This brings us closer to the most-recent UX request that I've seen: - muting displays the previous volume level in a disabled state rather than displaying 0% - volume down while muted drops the level to 0% - volume up while muted unmutes and raises the level to 25% if it was 0% or restores the previous level otherwise The requested behavior is actually to swell to the louder volume over three seconds in the volume-up-while-muted case instead of doing it instantly, but the mixer code doesn't support that at present, so I'm punting on it for now. BUG=chromium-os:8473, chromium-os:13618 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95873

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -46 lines) Patch
M chrome/browser/chromeos/brightness_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.cc View 1 6 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble_view.h View 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble_view.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 3 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Daniel Erat
9 years, 4 months ago (2011-08-03 22:26:06 UTC) #1
Daniel Erat
ping
9 years, 4 months ago (2011-08-06 00:24:36 UTC) #2
DaveMoore
9 years, 4 months ago (2011-08-07 16:44:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698