Fullscreen support for Lion.

chrome/browser/ui/cocoa/framed_browser_window.mm

Index: chrome/browser/ui/cocoa/framed_browser_window.mm
===================================================================
--- chrome/browser/ui/cocoa/framed_browser_window.mm	(revision 95287)
+++ chrome/browser/ui/cocoa/framed_browser_window.mm	(working copy)
@@ -13,6 +13,18 @@
 #import "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 #include "chrome/browser/themes/theme_service.h"
 
+// Provide the forward-declarations of new 10.7 SDK symbols so they can be
+// called when building with the 10.5 SDK.
+#if !defined(MAC_OS_X_VERSION_10_7) || \
+    MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
+
+@interface NSWindow (LionSDKDeclarations)
+- (void)toggleFullScreen:(id)sender;
+@end
+
+#endif  // MAC_OS_X_VERSION_10_7
+
+
 // Implementer's note: Moving the window controls is tricky. When altering the
 // code, ensure that:
 // - accessibility hit testing works
@@ -273,4 +285,19 @@
   return [super constrainFrameRect:frame toScreen:screen];
 }
 
+// This method is overridden in order to send the toggle fullscreen message
+// through the cross-platform browser framework before going fullscreen.  The
+// message will eventually come back as a call to |-toggleSystemFullScreen|,
+// which in turn calls AppKit's |NSWindow -toggleFullScreen:|.
+- (void)toggleFullScreen:(id)sender {
+  id delegate = [self delegate];
+  if ([delegate respondsToSelector:@selector(handleLionToggleFullscreen)])
+    [delegate handleLionToggleFullscreen];

[Mark Mentovai, 2011/08/04 19:18:17]

Is there a decent way to preserve |sender| through the call so that you can use
it when you call back into the system at line 300? I don’t know if the system
cares or not, but it might want to do something based on the value of sender.
Like determine if the command came from a menu or the window button. I don’t
know.

Not a huge deal, but if it’s easy, it’s easy. If we’re guaranteed to have
everything on the stack, you can even just stash sender in a member variable.

[rohitrao (ping after 24h), 2011/08/04 19:49:17]

Saving it on the stack looks like the most straightforward way of keeping it
around, since we can't pass any context into Browser::ExecuteCommand().  I think
there might be a way for the Browser to issue a fullscreen command without
anything going through BWC, which would make saving anything scary.

+}
+
+- (void)toggleSystemFullScreen {
+  if ([super respondsToSelector:@selector(toggleFullScreen:)])
+    [super toggleFullScreen:nil];
+}
+
 @end