Issue 7566013: Options: Fix the startup pages list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7566013: Options: Fix the startup pages list. (Closed)

Created:
9 years, 4 months ago by James Hawkins

Modified:
9 years, 4 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Options: Fix the startup pages list. * List was disabled even though the radio was checked. * When the list input gets focus (via tab), set this item as the selected index. BUG=89614 TEST=none R=csilv@chromium.or Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95301

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/options/inline_editable_list.js	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 4 months ago (2011-08-03 20:27:21 UTC) #3

lgtm

(seems like reasonable approach to me.  while getting the parentNode may be a
bit of a hack, I think that's a pretty safe assumption for a list item.)

Expand Messages | Collapse Messages