Issue 7566004: Move element deletion into element handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7566004: Move element deletion into element handlers (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move element deletion into element handlers BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8826

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -187 lines)			Patch
M	src/elements.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/elements.cc	View	1 2 3 4	5 chunks	+146 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4	3 chunks	+8 lines, -185 lines	0 comments	Download

Total messages: 2 (0 generated)

danno

Please take a look. It's the same element access pattern applied to element deletion.

9 years, 4 months ago (2011-08-03 16:03:31 UTC) #1

LGTM