Issue 7565021: Options: Focus the placeholder input element if an item was added through the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7565021: Options: Focus the placeholder input element if an item was added through the (Closed)

Created:
9 years, 4 months ago by James Hawkins

Modified:
9 years, 4 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Options: Focus the placeholder input element if an item was added through the placeholder. BUG=80038 TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95360

Patch Set 2 : Review fixes. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/inline_editable_list.js	View	1	5 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/7565021/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): http://codereview.chromium.org/7565021/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode250 chrome/browser/resources/options/inline_editable_list.js:250: // a short timeout in order for the ...

9 years, 4 months ago (2011-08-04 00:14:35 UTC) #2

James Hawkins

9 years, 4 months ago (2011-08-04 01:06:05 UTC) #3

http://codereview.chromium.org/7565021/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/inline_editable_list.js (right):

http://codereview.chromium.org/7565021/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/inline_editable_list.js:250: // a short timeout
in order for the attachment to occurr.
On 2011/08/04 00:14:35, csilv wrote:
> typo: "occur"

Done.

http://codereview.chromium.org/7565021/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/inline_editable_list.js:255:
self.parentNode.focusPlaceholder = false;
On 2011/08/04 00:14:35, csilv wrote:
> could this be simplified as:
>   list.focusPlaceholder = false;
> ?

Done.

Expand Messages | Collapse Messages

Issue 7565021: Options: Focus the placeholder input element if an item was added through the (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fixes. #

Messages