Issue 7565009: Fix out-of-bounds access in fetching propery names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7565009: Fix out-of-bounds access in fetching propery names (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium), SkyLined

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix out-of-bounds access in fetching propery names R=vegorov@chromium.org BUG=chromium:91517 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8823

Patch Set 1 #

Patch Set 2 : additional fixes #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM What about adding a regression test for this (e.g. as a cctest which can ...

9 years, 4 months ago (2011-08-03 16:06:55 UTC) #2

SkyLined

9 years, 4 months ago (2011-08-04 07:32:01 UTC) #3

On 2011/08/03 16:06:55, Vyacheslav Egorov wrote:
> LGTM
> 
> What about adding a regression test for this (e.g. as a cctest which can
> directly call GetLocalPropertyNames method on JSObject)?
FYI https://code.google.com/p/chromium/issues/detail?id=91572 has a repro that
can be be modified into a layout test.

Expand Messages | Collapse Messages