Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 7565008: DevTools: don't show the unresponsive dialog for inspected tabs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't reset DevToolsManager Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 21973397e6e9c311d0766b4829fc256a0a3c4b52..5c35fc571a9dfa7b565cdcfa988a14f1006c6586 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1758,6 +1758,14 @@ void TabContents::RendererUnresponsive(RenderViewHost* rvh,
if (rvh != render_view_host())
return;
+ // Ignore renderer unresponsive event if debugger is attached to the tab
+ // since the event may be a result of the renderer sitting on a breakpoint.
+ // See http://crbug.com/65458
+ DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
+ if (devtools_manager &&
+ devtools_manager->GetDevToolsClientHostFor(rvh) != NULL)
+ return;
+
if (is_during_unload) {
// Hang occurred while firing the beforeunload/unload handler.
// Pretend the handler fired so tab closing continues as if it had.
« no previous file with comments | « content/browser/debugger/devtools_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698