DevTools: don't show the unresponsive dialog for inspected tabs

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 1740 matching lines @@
     window->FocusConstrainedWindow();
   }
 }
 
 void TabContents::RendererUnresponsive(RenderViewHost* rvh,
                                        bool is_during_unload) {
   // Don't show hung renderer dialog for a swapped out RVH.
   if (rvh != render_view_host())
     return;
 
+  // Ignore renderer unresponsive event if debugger is attached to the tab
+  // since the event may be a result of the renderer sitting on a breakpoint.
+  // See http://crbug.com/65458
+  DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
+  if (devtools_manager && devtools_manager->IsBeingDebugged(rvh))

[pfeldman1, 2011/08/03 16:28:50]

What if the page has in fact hit the infinite loop? Consider the following
scenario:

- developer observes watchdog
- he wants to investigate the cause
- he opens devtools and watchdog vanishes

I think we should send the heart beat from the renderer (once a second or so)
while paused. That way we will reset the watchdog in browser and it will never
hit the limit while paused.

+    return;
+
   if (is_during_unload) {
     // Hang occurred while firing the beforeunload/unload handler.
     // Pretend the handler fired so tab closing continues as if it had.
     rvh->set_sudden_termination_allowed(true);
 
     if (!render_manager_.ShouldCloseTabOnUnresponsiveRenderer())
       return;
 
     // If the tab hangs in the beforeunload/unload handler there's really
     // nothing we can do to recover. Pretend the unload listeners have
@@ skipping 133 matching lines @@
 }
 
 void TabContents::SwapInRenderViewHost(RenderViewHost* rvh) {
   render_manager_.SwapInRenderViewHost(rvh);
 }
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }