Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: content/browser/debugger/devtools_manager.h

Issue 7565008: DevTools: don't show the unresponsive dialog for inspected tabs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renamed the test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
6 #define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 6 #define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 const std::string& value); 57 const std::string& value);
58 58
59 // Starts element inspection in the devtools agent. 59 // Starts element inspection in the devtools agent.
60 void SendInspectElement(RenderViewHost* inspected_rvh, int x, int y); 60 void SendInspectElement(RenderViewHost* inspected_rvh, int x, int y);
61 61
62 // Sends 'Attach' message to the agent using |dest_rvh| in case 62 // Sends 'Attach' message to the agent using |dest_rvh| in case
63 // there is a DevToolsClientHost registered for the |inspected_rvh|. 63 // there is a DevToolsClientHost registered for the |inspected_rvh|.
64 void OnNavigatingToPendingEntry(RenderViewHost* inspected_rvh, 64 void OnNavigatingToPendingEntry(RenderViewHost* inspected_rvh,
65 RenderViewHost* dest_rvh, 65 RenderViewHost* dest_rvh,
66 const GURL& gurl); 66 const GURL& gurl);
67 bool IsBeingDebugged(RenderViewHost* inspected_rvh);
pfeldman1 2011/08/03 16:28:50 Call site could use GetDevToolsClientHostFor inste
yurys 2011/08/04 08:59:15 Done.
67 68
68 // Invoked when a tab is replaced by another tab. This is triggered by 69 // Invoked when a tab is replaced by another tab. This is triggered by
69 // TabStripModel::ReplaceTabContentsAt. 70 // TabStripModel::ReplaceTabContentsAt.
70 void TabReplaced(TabContents* old_tab, TabContents* new_tab); 71 void TabReplaced(TabContents* old_tab, TabContents* new_tab);
71 72
72 // Detaches client host and returns cookie that can be used in 73 // Detaches client host and returns cookie that can be used in
73 // AttachClientHost. 74 // AttachClientHost.
74 int DetachClientHost(RenderViewHost* from_rvh); 75 int DetachClientHost(RenderViewHost* from_rvh);
75 76
76 // Attaches orphan client host to new render view host. 77 // Attaches orphan client host to new render view host.
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 OrphanClientHosts; 134 OrphanClientHosts;
134 OrphanClientHosts orphan_client_hosts_; 135 OrphanClientHosts orphan_client_hosts_;
135 int last_orphan_cookie_; 136 int last_orphan_cookie_;
136 137
137 NotificationRegistrar registrar_; 138 NotificationRegistrar registrar_;
138 139
139 DISALLOW_COPY_AND_ASSIGN(DevToolsManager); 140 DISALLOW_COPY_AND_ASSIGN(DevToolsManager);
140 }; 141 };
141 142
142 #endif // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 143 #endif // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698