Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/sync/glue/extension_util.cc

Issue 7564037: Apps/Extensions Sync refactoring -- delete most of the old glue, implement new sync API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Release build warning :-/ Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/extension_util.h ('k') | chrome/browser/sync/glue/extension_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/extension_util.cc
diff --git a/chrome/browser/sync/glue/extension_util.cc b/chrome/browser/sync/glue/extension_util.cc
deleted file mode 100644
index 3c3162a8f0385c65ba955ede24bb4c8f15390e5d..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/glue/extension_util.cc
+++ /dev/null
@@ -1,102 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/sync/glue/extension_util.h"
-
-#include <sstream>
-
-#include "base/logging.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/version.h"
-#include "chrome/browser/extensions/extension_sync_data.h"
-#include "chrome/browser/sync/protocol/extension_specifics.pb.h"
-#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_constants.h"
-
-namespace browser_sync {
-
-bool IsExtensionValid(const Extension& extension) {
- // TODO(akalin): Figure out if we need to allow some other types.
- if (extension.location() != Extension::INTERNAL) {
- // We have a non-standard location.
- return false;
- }
-
- // Disallow extensions with non-gallery auto-update URLs for now.
- //
- // TODO(akalin): Relax this restriction once we've put in UI to
- // approve synced extensions.
- if (!extension.update_url().is_empty() &&
- (extension.update_url() != Extension::GalleryUpdateUrl(false)) &&
- (extension.update_url() != Extension::GalleryUpdateUrl(true))) {
- return false;
- }
-
- // Disallow extensions with native code plugins.
- //
- // TODO(akalin): Relax this restriction once we've put in UI to
- // approve synced extensions.
- if (!extension.plugins().empty()) {
- return false;
- }
-
- return true;
-}
-
-std::string ExtensionSpecificsToString(
- const sync_pb::ExtensionSpecifics& specifics) {
- std::stringstream ss;
- ss << "{ ";
- ss << "id: " << specifics.id() << ", ";
- ss << "version: " << specifics.version() << ", ";
- ss << "update_url: " << specifics.update_url() << ", ";
- ss << "enabled: " << specifics.enabled() << ", ";
- ss << "incognito_enabled: " << specifics.incognito_enabled() << ", ";
- ss << "name: " << specifics.name();
- ss << " }";
- return ss.str();
-}
-
-bool SpecificsToSyncData(
- const sync_pb::ExtensionSpecifics& specifics,
- ExtensionSyncData* sync_data) {
- if (!Extension::IdIsValid(specifics.id())) {
- return false;
- }
-
- scoped_ptr<Version> version(
- Version::GetVersionFromString(specifics.version()));
- if (!version.get()) {
- return false;
- }
-
- // The update URL must be either empty or valid.
- GURL update_url(specifics.update_url());
- if (!update_url.is_empty() && !update_url.is_valid()) {
- return false;
- }
-
- sync_data->id = specifics.id();
- sync_data->update_url = update_url;
- sync_data->version = *version;
- sync_data->enabled = specifics.enabled();
- sync_data->incognito_enabled = specifics.incognito_enabled();
- sync_data->name = specifics.name();
- return true;
-}
-
-void SyncDataToSpecifics(
- const ExtensionSyncData& sync_data,
- sync_pb::ExtensionSpecifics* specifics) {
- DCHECK(Extension::IdIsValid(sync_data.id));
- DCHECK(!sync_data.uninstalled);
- specifics->set_id(sync_data.id);
- specifics->set_update_url(sync_data.update_url.spec());
- specifics->set_version(sync_data.version.GetString());
- specifics->set_enabled(sync_data.enabled);
- specifics->set_incognito_enabled(sync_data.incognito_enabled);
- specifics->set_name(sync_data.name);
-}
-
-} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/extension_util.h ('k') | chrome/browser/sync/glue/extension_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698