Apps/Extensions Sync refactoring -- delete most of the old glue, implement new sync API.

chrome/common/extensions/extension.h

Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index e46cba12900b5a5b17993deb43983e434283259e..b8b49553aa43cf4780e28b5a272fe100ed58b542 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -105,6 +105,12 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
     TYPE_PACKAGED_APP
   };
 
+  enum SyncType {

[asargent_no_longer_on_chrome, 2011/08/12 20:50:39]

Do these literal values end up hardcoded into protocol buffers or anything in
the sync system? If so include a warning about not removing / changing order of
items (similar to the above one for Type). 

Also, from looking at the implementation of GetSyncType(), more items than you
might think end up with SYNC_TYPE_NONE - ie it's not just a sentinel value, but
one that many extensions have for a valid reason. It might be worth having a
brief comment about that. 

+    SYNC_TYPE_NONE = 0,
+    SYNC_TYPE_EXTENSION,
+    SYNC_TYPE_APP
+  };
+
   // An NPAPI plugin included in the extension.
   struct PluginInfo {
     FilePath path;  // Path to the plugin.
@@ -481,6 +487,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
   // Returns true if this extension or app includes areas within |origin|.
   bool OverlapsWithOrigin(const GURL& origin) const;
 
+  // Returns the sync bucket to use for this extension.
+  SyncType GetSyncType() const;
+
   // Accessors:
 
   const FilePath& path() const { return path_; }