Apps/Extensions Sync refactoring -- delete most of the old glue, implement new sync API.

chrome/common/extensions/extension.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 87 matching lines @@
   // as this is used in UMA_HISTOGRAM_ENUMERATIONs about extensions.
   enum Type {
     TYPE_UNKNOWN = 0,
     TYPE_EXTENSION,
     TYPE_THEME,
     TYPE_USER_SCRIPT,
     TYPE_HOSTED_APP,
     TYPE_PACKAGED_APP
   };
 
+  enum SyncType {

[asargent_no_longer_on_chrome, 2011/08/12 20:50:39]

Do these literal values end up hardcoded into protocol buffers or anything in
the sync system? If so include a warning about not removing / changing order of
items (similar to the above one for Type). 

Also, from looking at the implementation of GetSyncType(), more items than you
might think end up with SYNC_TYPE_NONE - ie it's not just a sentinel value, but
one that many extensions have for a valid reason. It might be worth having a
brief comment about that. 

+    SYNC_TYPE_NONE = 0,
+    SYNC_TYPE_EXTENSION,
+    SYNC_TYPE_APP
+  };
+
   // An NPAPI plugin included in the extension.
   struct PluginInfo {
     FilePath path;  // Path to the plugin.
     bool is_public;  // False if only this extension can load this plugin.
   };
 
   // An NaCl module included in the extension.
   struct NaClModuleInfo {
     GURL url;
     std::string mime_type;
@@ skipping 356 matching lines @@
   // extension page itself.
   bool CanCaptureVisiblePage(const GURL& page_url, std::string* error) const;
 
   // Returns true if this extension updates itself using the extension
   // gallery.
   bool UpdatesFromGallery() const;
 
   // Returns true if this extension or app includes areas within |origin|.
   bool OverlapsWithOrigin(const GURL& origin) const;
 
+  // Returns the sync bucket to use for this extension.
+  SyncType GetSyncType() const;
+
   // Accessors:
 
   const FilePath& path() const { return path_; }
   const GURL& url() const { return extension_url_; }
   Location location() const { return location_; }
   const std::string& id() const { return id_; }
   const Version* version() const { return version_.get(); }
   const std::string VersionString() const;
   const std::string& name() const { return name_; }
   const std::string& public_key() const { return public_key_; }
@@ skipping 438 matching lines @@
   // only contain the removed permissions.
   const ExtensionPermissionSet* permissions;
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const ExtensionPermissionSet* permissions,
       Reason reason);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_