Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 7564036: Gtk: Fix the Sync error button on the bookmarks bar. (Closed)

Created:
9 years, 4 months ago by James Hawkins
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Gtk: Fix the Sync error button on the bookmarks bar. Set the label and tooltip text. BUG=90771 TEST=none R=erg@chromium.org,thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95370

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
9 years, 4 months ago (2011-08-04 00:55:00 UTC) #1
Lei Zhang
Is that the right bug #? LGTM http://codereview.chromium.org/7564036/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/7564036/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc#newcode273 chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:273: GtkSettings *default_settings ...
9 years, 4 months ago (2011-08-04 00:58:54 UTC) #2
Elliot Glaysher
LGTM. I echo thestig's comment about the bug.
9 years, 4 months ago (2011-08-04 01:03:37 UTC) #3
James Hawkins
Fixed the bug number. http://codereview.chromium.org/7564036/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/7564036/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc#newcode273 chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:273: GtkSettings *default_settings = gtk_settings_get_default(); On ...
9 years, 4 months ago (2011-08-04 01:07:58 UTC) #4
Lei Zhang
9 years, 4 months ago (2011-08-04 01:09:07 UTC) #5
LGTM++

Powered by Google App Engine
This is Rietveld 408576698