Issue 7564029: Use javascript strict mode throughout a number of net-internals files.

Issue 7564029: Use javascript strict mode throughout a number of net-internals files. (Closed)

Created:
9 years, 4 months ago by eroman

Modified:
9 years, 4 months ago

Reviewers:
mmenke

CC:
chromium-reviews, tfarina, arv (Not doing code reviews), mmenke, eroman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use javascript strict mode throughout a number of net-internals files. BUG=90857 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95331

Patch Set 2 : fix one more var #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -137 lines)			Patch
M	chrome/browser/resources/net_internals/browser_bridge.js	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/net_internals/capture_view.js	View		2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/net_internals/dns_view.js	View		2 chunks	+13 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/net_internals/events_view.js	View		3 chunks	+27 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/net_internals/export_view.js	View		1 chunk	+13 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/net_internals/hsts_view.js	View		2 chunks	+14 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/net_internals/http_cache_view.js	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/net_internals/http_throttling_view.js	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/net_internals/import_view.js	View		2 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/net_internals/logs_view.js	View		4 chunks	+20 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/prerender_view.js	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/net_internals/proxy_view.js	View		2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/net_internals/resizable_vertical_split_view.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/service_providers_view.js	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/net_internals/sockets_view.js	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/net_internals/spdy_view.js	View		2 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/net_internals/test_view.js	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/net_internals/util.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eroman

I found a couple accidental globals in the process, so this is definitely worthwhile pattern.

9 years, 4 months ago (2011-08-03 20:45:56 UTC) #1

eroman

http://codereview.chromium.org/7564029/diff/1/chrome/browser/resources/net_internals/util.js File chrome/browser/resources/net_internals/util.js (right): http://codereview.chromium.org/7564029/diff/1/chrome/browser/resources/net_internals/util.js#newcode148 chrome/browser/resources/net_internals/util.js:148: function assertFirstConstructorCall(ctor) { I added this as an extra ...

9 years, 4 months ago (2011-08-03 20:46:54 UTC) #2

mmenke

LGTM. Very nice. http://codereview.chromium.org/7564029/diff/1/chrome/browser/resources/net_internals/util.js File chrome/browser/resources/net_internals/util.js (right): http://codereview.chromium.org/7564029/diff/1/chrome/browser/resources/net_internals/util.js#newcode148 chrome/browser/resources/net_internals/util.js:148: function assertFirstConstructorCall(ctor) { On 2011/08/03 20:46:54, ...

9 years, 4 months ago (2011-08-03 20:50:36 UTC) #3

eroman

9 years, 4 months ago (2011-08-03 21:49:33 UTC) #4

FYI: During my testing I found one more violation of strict mode, updated in
patchset 2. Going to commit now.

Expand Messages | Collapse Messages