Issue 7564028: Added version info to WebUI

Issue 7564028: Added version info to WebUI (Closed)

Created:
9 years, 4 months ago by whywhat

Modified:
9 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, rharrison, arv (Not doing code reviews), nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Added version info to WebUI R=xiyuan@chromium.org BUG=chromium-os:18608 TEST=Verify that on WebUI OOBE and Login pages there's version info label. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95406

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added boot times label #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+534 lines, -306 lines)			Patch
M	chrome/browser/chromeos/login/background_view.h	View		6 chunks	+12 lines, -46 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View		4 chunks	+16 lines, -161 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/version_info_updater.h	View		1 chunk	+96 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/version_info_updater.cc	View	1	1 chunk	+207 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h	View		1 chunk	+73 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View		1 chunk	+100 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View		4 chunks	+1 line, -99 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM FYI, coderview site would recognize a cros bug if you put a "-" between ...

9 years, 4 months ago (2011-08-03 21:06:09 UTC) #2

whywhat

9 years, 4 months ago (2011-08-04 10:04:36 UTC) #3

Thanks for the tip.

http://codereview.chromium.org/7564028/diff/1/chrome/browser/chromeos/login/v...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

http://codereview.chromium.org/7564028/diff/1/chrome/browser/chromeos/login/v...
chrome/browser/chromeos/login/version_info_updater.cc:37:
VersionInfoUpdater::~VersionInfoUpdater() {}
On 2011/08/03 21:06:09, xiyuan wrote:
> nit: "}" on the next line?

Done.

Expand Messages | Collapse Messages