Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 7564013: Roll skia to r2034 (and add new gl bindings) (Closed)

Created:
9 years, 4 months ago by bsalomon
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Roll skia to r2034 (and add new gl bindings) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95462

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gl_mock.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M ui/gfx/gl/gl_interface.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
The only failures that looked suspicious are in win_layout and win_layout_rel: compositing/geometry/horizontal-scroll-composited.html compositing/iframes/composited-iframe-alignment.html I can ...
9 years, 4 months ago (2011-08-03 18:56:47 UTC) #1
reed1
LGTM
9 years, 4 months ago (2011-08-03 20:27:44 UTC) #2
tony
webkit/glue lgtm
9 years, 4 months ago (2011-08-03 20:33:45 UTC) #3
apatrick_chromium
9 years, 4 months ago (2011-08-04 17:38:25 UTC) #4
LGTM if you are confident the failing tests are unrelated.

Powered by Google App Engine
This is Rietveld 408576698