src/objects-inl.h - Issue 7564010: Add missing bounds check in FixedArray::set for smis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 7564010: Add missing bounds check in FixedArray::set for smis (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 3f0eeb4301794db78f1480c2b1fac4556db7cd0f..9789118f777bb24e337db1a84493d065aa0142a9 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1612,6 +1612,7 @@ Object* FixedArray::get(int index) {

void FixedArray::set(int index, Smi* value) {

ASSERT(map() != HEAP->fixed_cow_array_map());

+ ASSERT(index >= 0 && index < this->length());

ASSERT(reinterpret_cast<Object*>(value)->IsSmi());

int offset = kHeaderSize + index * kPointerSize;

WRITE_FIELD(this, offset, value);

« no previous file with comments | « no previous file | no next file » | no next file with comments »