Issue 7563026: Fix crash in ScreenRecorder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7563026: Fix crash in ScreenRecorder (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 4 months ago

Reviewers:
dmac, Alpha Left Google

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash in ScreenRecorder BUG=91620 TEST=Host doesn't crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95440

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	remoting/host/screen_recorder.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	remoting/host/screen_recorder.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmac

LGTM with nit http://codereview.chromium.org/7563026/diff/1/remoting/host/screen_recorder.h File remoting/host/screen_recorder.h (right): http://codereview.chromium.org/7563026/diff/1/remoting/host/screen_recorder.h#newcode183 remoting/host/screen_recorder.h:183: // Flags that indicate network and ...

9 years, 4 months ago (2011-08-04 01:27:27 UTC) #2

Sergey Ulanov

9 years, 4 months ago (2011-08-04 17:44:05 UTC) #3

http://codereview.chromium.org/7563026/diff/1/remoting/host/screen_recorder.h
File remoting/host/screen_recorder.h (right):

http://codereview.chromium.org/7563026/diff/1/remoting/host/screen_recorder.h...
remoting/host/screen_recorder.h:183: // Flags that indicate network and encoder
are stopped. This
On 2011/08/04 01:27:28, dmac wrote:
> s/This/These/
> 
> and what do you mean by corresponding threads? (I think I know what you mean,
> but as somebody reading this code for the first time I wouldn't).

Done.

Expand Messages | Collapse Messages