TaskClosureAdapter::Run does not invoke the task if it is null.

TaskClosureAdapter::Run does not invoke the task if it is null.

This is an attempt to fix http://crbug.com/81449. If this actually fixes it then there is probably something more fundamentally wrong.

BUG=81449
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95441

[awong, 2011-08-04 01:32:00]

LGTM

On Wed, Aug 3, 2011 at 5:55 PM,  <apatrick@chromium.org> wrote:
> Reviewers: awong,
>
> Description:
> TaskClosureAdapter::Run does not invoke the task if it is null.
>
> This is an attempt to fix http://crbug.com/81449. If this actually fixes it
> then
> there is probably something more fundamentally wrong.
>
> BUG=81449
>
> Please review this at http://codereview.chromium.org/7563025/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/task.cc
>
>
> Index: base/task.cc
> ===================================================================
> --- base/task.cc        (revision 95345)
> +++ base/task.cc        (working copy)
> @@ -53,9 +53,11 @@
>  }
>
>  void TaskClosureAdapter::Run() {
> -  task_->Run();
> -  delete task_;
> -  task_ = NULL;
> +  if (task_) {
> +    task_->Run();
> +    delete task_;
> +    task_ = NULL;
> +  }
>  }
>
>  // Don't leak tasks by default.
>
>
>

[apatrick_chromium, 2011-08-04 17:49:25]

+darin for owners

[darin (slow to review), 2011-08-04 17:52:30]

OK, LGTM

This would imply that either Run is being called multiple times, or we are
initializing with a null Task :-(