Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7563023: Multi-Profiles: Remove new profile setup UI (Closed)

Created:
9 years, 4 months ago by sail
Modified:
9 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Multi-Profiles: Remove new profile setup UI After some discussion we decided that we no longer want a new profile setup UI. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -597 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/new_profile.css View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/resources/new_profile.html View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/resources/new_profile.js View 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_handler.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_handler.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_ui.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_ui.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sail
erg: for chrome/browser/profiles jhawkins: for everything else
9 years, 4 months ago (2011-08-03 23:12:16 UTC) #1
Elliot Glaysher
Profile changes lgtm
9 years, 4 months ago (2011-08-03 23:36:39 UTC) #2
James Hawkins
LGTM
9 years, 4 months ago (2011-08-04 00:59:44 UTC) #3
commit-bot: I haz the power
Change committed as 95379
9 years, 4 months ago (2011-08-04 03:11:53 UTC) #4
Adam Malcontenti-Wilson
9 years, 4 months ago (2011-08-13 18:12:00 UTC) #5 
I really liked that UI, the New Tab Page is worthless in comparison. =( Is it
being replaced by anything special on the ntp, or is the ntp staying as it is?

Powered by Google App Engine
This is Rietveld 408576698