Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 7563021: Added WebGL conformance test expectation script. (Closed)

Created:
9 years, 4 months ago by jrt
Modified:
9 years, 4 months ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Added WebGL conformance test expectation script. Using the WebKit LayoutTests as a template, you can now specify slow or failing tests to the header generating script. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95510

Patch Set 1 #

Patch Set 2 : . #

Total comments: 7

Patch Set 3 : Updated regex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/gpu/generate_webgl_conformance_test_list.py View 1 2 4 chunks +45 lines, -2 lines 0 comments Download
A chrome/test/gpu/webgl_conformance_test_expectations.txt View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jrt
More green tests on the way.
9 years, 4 months ago (2011-08-03 22:50:00 UTC) #1
Zhenyao Mo
On 2011/08/03 22:50:00, jrt wrote: > More green tests on the way. Thanks for getting ...
9 years, 4 months ago (2011-08-04 17:56:05 UTC) #2
Zhenyao Mo
http://codereview.chromium.org/7563021/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py File chrome/test/gpu/generate_webgl_conformance_test_list.py (right): http://codereview.chromium.org/7563021/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py#newcode44 chrome/test/gpu/generate_webgl_conformance_test_list.py:44: r'^(?P<BUG>\d+)' <BUG> should allow more than numbers http://codereview.chromium.org/7563021/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py#newcode47 chrome/test/gpu/generate_webgl_conformance_test_list.py:47: ...
9 years, 4 months ago (2011-08-04 17:56:11 UTC) #3
jrt
New snapshot uploaded. http://codereview.chromium.org/7563021/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py File chrome/test/gpu/generate_webgl_conformance_test_list.py (right): http://codereview.chromium.org/7563021/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py#newcode44 chrome/test/gpu/generate_webgl_conformance_test_list.py:44: r'^(?P<BUG>\d+)' On 2011/08/04 17:56:11, Zhenyao Mo ...
9 years, 4 months ago (2011-08-04 18:57:51 UTC) #4
Zhenyao Mo
LGTM
9 years, 4 months ago (2011-08-04 19:02:27 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-04 21:55:11 UTC) #6
Change committed as 95510

Powered by Google App Engine
This is Rietveld 408576698