Dont retry sync in case of auth errors.

chrome/browser/sync/engine/net/server_connection_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/net/server_connection_manager.h"
 
 #include <errno.h>
 
 #include <ostream>
 #include <string>
@@ skipping 174 matching lines @@
     const PostBufferParams* params, ScopedServerStatusWatcher* watcher) {
   string path =
       MakeSyncServerPath(proto_sync_path(), MakeSyncQueryString(client_id_));
   return PostBufferToPath(params, path, auth_token(), watcher);
 }
 
 bool ServerConnectionManager::PostBufferToPath(const PostBufferParams* params,
     const string& path, const string& auth_token,
     ScopedServerStatusWatcher* watcher) {
   DCHECK(watcher != NULL);
+
+  if (auth_token.empty()) {

[tim (not reviewing), 2011/08/04 00:24:40]

could we put all this in syncapi_server_connection_manager, since it already
examines auth_token and SYNC_AUTH_ERROR?

[lipalani1, 2011/08/04 01:14:33]

CheckTime uses that code and we probably dont want to mess with that.
On 2011/08/04 00:24:40, timsteele wrote:

+    params->response->server_status = HttpResponse::SYNC_AUTH_ERROR;
+    return false;
+  }
+
   scoped_ptr<Post> post(MakePost());
   post->set_timing_info(params->timing_info);
   bool ok = post->Init(path.c_str(), auth_token, params->buffer_in,
                        params->response);
 
+  if (params->response->server_status == HttpResponse::SYNC_AUTH_ERROR) {
+    reset_auth_token();
+  }
+
   if (!ok || RC_REQUEST_OK != params->response->response_code) {
     IncrementErrorCount();
     return false;
   }
 
   if (post->ReadBufferResponse(params->buffer_out, params->response, true)) {
     params->response->server_status = HttpResponse::SERVER_CONNECTION_OK;
     server_reachable_ = true;
     return true;
   }
@@ skipping 169 matching lines @@
 }
 
 std::ostream& operator << (std::ostream& s, const struct HttpResponse& hr) {
   s << " Response Code (bogus on error): " << hr.response_code;
   s << " Content-Length (bogus on error): " << hr.content_length;
   s << " Server Status: " << hr.server_status;
   return s;
 }
 
 }  // namespace browser_sync