Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: Source/WebCore/storage/AbstractDatabase.h

Issue 7563014: Merge 92155 - [Chromium] WebSQLDatabase version handling is broken in multi-process browsers. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebCore/storage/AbstractDatabase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/storage/AbstractDatabase.h
===================================================================
--- Source/WebCore/storage/AbstractDatabase.h (revision 92303)
+++ Source/WebCore/storage/AbstractDatabase.h (working copy)
@@ -71,12 +71,6 @@
void interrupt();
bool isInterrupted();
- // FIXME: move all version-related methods to a DatabaseVersionTracker class
- bool versionMatchesExpected() const;
- void setExpectedVersion(const String& version);
- bool getVersionFromDatabase(String& version);
- bool setVersionInDatabase(const String& version);
-
void disableAuthorizer();
void enableAuthorizer();
void setAuthorizerReadOnly();
@@ -91,6 +85,10 @@
virtual void closeImmediately() = 0;
protected:
+ friend class SQLTransactionSync;
+ friend class SQLTransaction;
+ friend class ChangeVersionWrapper;
+
AbstractDatabase(ScriptExecutionContext*, const String& name, const String& expectedVersion,
const String& displayName, unsigned long estimatedSize);
@@ -98,6 +96,14 @@
virtual bool performOpenAndVerify(bool shouldSetVersionInNewDatabase, ExceptionCode& ec);
+ bool getVersionFromDatabase(String& version, bool shouldCacheVersion = true);
+ bool setVersionInDatabase(const String& version, bool shouldCacheVersion = true);
+ void setExpectedVersion(const String&);
+ const String& expectedVersion() const { return m_expectedVersion; }
+ String getCachedVersion()const;
+ void setCachedVersion(const String&);
+ bool getActualVersionForTransaction(String& version);
+
static const String& databaseInfoTableName();
RefPtr<ScriptExecutionContext> m_scriptExecutionContext;
« no previous file with comments | « no previous file | Source/WebCore/storage/AbstractDatabase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698