GTK: Possible WM_CLASS fix.

GTK: Possible WM_CLASS fix.

Previously, we were setting the wmclass properties differently depending on how closely the DE we were running in was conforming to the ICCM standard. Now we just do the right thing all the time.

BUG=20587
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95492

[Elliot Glaysher, 2011-08-04 00:13:02]

Evan: It looks like you've modified how we do WM_CLASS stuff in the interim for
gnome 3. If I understand Trevi correctly, this is what needs to be done for
newer libwncks, but I want your input.

[Marco Trevisan (Treviño), 2011-08-04 11:43:52]

On 2011/08/04 00:13:02, Elliot Glaysher wrote:
> Evan: It looks like you've modified how we do WM_CLASS stuff in the interim
for
> gnome 3. If I understand Trevi correctly, this is what needs to be done for
> newer libwncks, but I want your input.

Yes this needs to be done to set the proper WM_CLASS values, not just for
libwnck. Libwnck wasn't able to get these values correctly, that's why we used
this workaround.

However the fix seems fine, basically an app pointing to google.com should have
WM_CLASS(STRING) = "google.com", "Chromium-browser"

(check it with xprop, but this change seems fine).

[Evan Martin, 2011-08-04 18:40:57]

At this point I'm exhausted with all of this; I also stopped using gnome3
because it was way too slow.  This change LGTM purely by virtue of being less
code, though I'd like it if you updated the review description to describe *why*
you're doing this.

[commit-bot: I haz the power, 2011-08-04 21:06:06]

Change committed as 95492

[Marco Trevisan (Treviño), 2011-08-05 00:33:49]

On 2011/08/04 21:06:06, I haz the power (commit-bot) wrote:
> Change committed as 95492

Thank you.