Issue 7562019: ntp: remove dead first run code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7562019: ntp: remove dead first run code (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
csilv, Dan Beam

CC:
chromium-reviews, estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp: remove dead first run code my favorite part is: static bool first_view = true; if (first_view) { first_view = false; } BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95517

Patch Set 1 #

Total comments: 1

Patch Set 2 : compile fix #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -46 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		3 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/startup/feature_startup_test.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

http://codereview.chromium.org/7562019/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (left): http://codereview.chromium.org/7562019/diff/1/chrome/common/chrome_switches.cc#oldcode272 chrome/common/chrome_switches.cc:272: const char kDisableNewTabFirstRun[] = "disable-new-tab-first-run"; talked with estade about ...

9 years, 4 months ago (2011-08-04 19:15:38 UTC) #3

lgtm

Expand Messages | Collapse Messages