Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: chrome/browser/trials/http_throttling_trial.cc

Issue 7562018: Increase size of trial and increase its duration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comment to say M15 instead of M15. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/trials/http_throttling_trial.cc
diff --git a/chrome/browser/trials/http_throttling_trial.cc b/chrome/browser/trials/http_throttling_trial.cc
index 9fa139938d273c253c1f8a16f6f85582ed3034b2..27fe2e5b9163f55cc57d29dd548c13b5eb01ba23 100644
--- a/chrome/browser/trials/http_throttling_trial.cc
+++ b/chrome/browser/trials/http_throttling_trial.cc
@@ -22,12 +22,12 @@ void CreateHttpThrottlingTrial(PrefService* prefs) {
if (!base::FieldTrialList::IsOneTimeRandomizationEnabled())
return;
- // Probability for each trial group (the experiment and the control) is 5%.
- const base::FieldTrial::Probability kEachGroupProbability = 5;
+ // Probability for each trial group (the experiment and the control) is 25%.
+ const base::FieldTrial::Probability kEachGroupProbability = 25;
const base::FieldTrial::Probability kTotalProbability = 100;
- // Disable trial a couple of days before M14 branch point.
+ // Disable trial a couple of days before M15 branch point.
scoped_refptr<base::FieldTrial> trial(new base::FieldTrial(
- "HttpThrottlingEnabled", kTotalProbability, "Default", 2011, 7, 23));
+ "HttpThrottlingEnabled", kTotalProbability, "Default", 2011, 9, 20));
trial->UseOneTimeRandomization();
// If the user has touched the control for whether throttling is enabled
@@ -37,9 +37,13 @@ void CreateHttpThrottlingTrial(PrefService* prefs) {
int experiment_group =
trial->AppendGroup("Experiment", kEachGroupProbability);
- // The behavior for the control group is the same as for the default group.
- // The point of having the control group is that it's the same size as
- // the experiment group and selected the same way, so we get an
+ // The behavior for the control group is mostly the same as for
+ // the default group, with the difference that we are guaranteed
+ // that none of the users in the control group have manually
+ // changed the setting (under chrome://net-internals/) for whether
+ // throttling should be turned on or not. The other point of
+ // having the control group is that it's the same size as the
+ // experiment group and selected the same way, so we get an
// apples-to-apples comparison of histograms.
trial->AppendGroup("Control", kEachGroupProbability);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698