[ChromeOS] Fix login wrong password handling.

[ChromeOS] Fix login wrong password handling.

- Return cryptohome final failure state instead of intermediate ones if
  there is no parallel online attempt (when using oauth login);
- Fix js error when using Gaia sign-in;

BUG=chromium-os:18651
TEST=Verify fix for chromium-os:18651.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95358

[xiyuan, 2011-08-03 17:42:05]

When we use OAuthLogin, online attempt happens after cryptohome mount and
profile load. This CL makes the cryptohome mount failure final since there is no
parallel online attempt.

[Chris Masone, 2011-08-03 17:43:48]

On 2011/08/03 17:42:05, xiyuan wrote:
> When we use OAuthLogin, online attempt happens after cryptohome mount and
> profile load. This CL makes the cryptohome mount failure final since there is
no
> parallel online attempt.

parallel_authenticator.cc change LGTM, though it'd be nice to see a unit test

[xiyuan, 2011-08-03 18:32:33]

Added current_state_->online_complete() case to allow intermediate cryptohome
states. This allows password change detection logic to kick in when user signs
in using Gaia.

Will figure out how to add a test.

[xiyuan, 2011-08-03 21:15:04]

CL updated.
- Fixed broken ResolvePossiblePwChange and ResolveNoMount;
- Added 3 new tests: ResolvePossiblePwChangeToFailedMount,
ResolveNoMountToFailedMount and ResolveNeedOldPw;

[zel, 2011-08-03 21:18:23]

LGTM

[Chris Masone, 2011-08-03 21:42:46]

LGTM

(linux_chromeos tryjob would be nice, though)

[xiyuan, 2011-08-03 21:47:17]

On 2011/08/03 21:42:46, Chris Masone wrote:
> LGTM
> 
> (linux_chromeos tryjob would be nice, though)

Yep, running it. Otherwise there is no point to try, right? I found codereview
site sometime would miss running tryjobs.

http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...