Print an error when trying to launch an incognito browser and incognito is disabled.

Print an error when trying to launch an incognito browser and incognito is disabled.

BUG=90759
TEST=Set the IncognitoEnabled policy to false. Start the browser with the --incognito switch. An error message should be displayed, and a normal browser is started.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96039

[Joao da Silva, 2011-08-04 09:04:17]

A small change to close the bug, please review. Thanks!

[sky, 2011-08-08 14:01:50]

http://codereview.chromium.org/7562009/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/7562009/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:546: LOG(ERROR) << "Incognito mode disabled by
policy, launching a normal "
At best this should be a warning, not an error.

[Joao da Silva, 2011-08-08 17:34:40]

Thanks for reviewing! Please have another look.

http://codereview.chromium.org/7562009/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/7562009/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:546: LOG(ERROR) << "Incognito mode disabled by
policy, launching a normal "
On 2011/08/08 14:01:50, sky wrote:
> At best this should be a warning, not an error.

Done.

[sky, 2011-08-08 20:19:01]

LGTM

[commit-bot: I haz the power, 2011-08-09 13:13:43]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux, revision is 95980, job name
was 7562009-4002 (retry) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-08-09 13:28:28]

Try job failure for 7562009-4002 (retry) on linux for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-08-09 19:43:29]

Change committed as 96039