Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 7562005: Revert "Make window.{undefined,NaN,Infinity} read-only" (Closed)

Created:
9 years, 4 months ago by Jakob Kummerow
Modified:
9 years, 4 months ago
Reviewers:
danno
CC:
v8-dev, Kevin Millikin (Chromium)
Visibility:
Public.

Description

Revert "Make window.{undefined,NaN,Infinity} read-only" This reverts r8766. TEST=WebKit LayoutTests green again. Committed: http://code.google.com/p/v8/source/detail?r=8800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M src/runtime.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/v8natives.js View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/es5conform/es5conform.status View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/undeletable-functions.js View 2 chunks +1 line, -3 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Please rubber-stamp.
9 years, 4 months ago (2011-08-03 09:32:36 UTC) #1
Jakob Kummerow
[Kevin to CC] Danno: please rubber-stamp.
9 years, 4 months ago (2011-08-03 09:47:34 UTC) #2
danno
9 years, 4 months ago (2011-08-03 09:51:32 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698