Speculative fix for crash. Crashes seem to indicate

Speculative fix for crash. Crashes seem to indicate
ExtensionsTabModule is asking for the id of a deleted TabContents. My guess is
ExtensionWebNavigationTabObserver is adding an entry for a TabContents
that is later deleted and ExtensionWebNavigationTabObserver doesn't
clean up it's map so that if another TabContents ends up with the same
pointer value we get a crash.

BUG=91385
TEST=none
R=jochen@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95818

[sky, 2011-08-03 03:44:12]

Matt, passing your way since jochen is out. If you prefer to wait till he is
back just say so.

  -Scott

[sky, 2011-08-03 17:58:22]

http://codereview.chromium.org/7562003/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_webnavigation_api.cc (right):

http://codereview.chromium.org/7562003/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_webnavigation_api.cc:431:
pending_tab_contents_.erase(tab_contents);
Seems like it's actually the source that is null. I've updated to remove both.

[Matt Perry, 2011-08-03 19:00:21]

LGTM

http://codereview.chromium.org/7562003/diff/7/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_webnavigation_api.cc (right):

http://codereview.chromium.org/7562003/diff/7/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_webnavigation_api.cc:437:
pending_tab_contents_.erase(to_erase);
FYI, erase(i++) is equivalent

[sky, 2011-08-03 22:28:01]

Updated.

Thanks,

  -Scott

[Matt Perry, 2011-08-03 22:30:05]

still lgtm

[jochen (gone - plz use gerrit), 2011-08-08 15:19:24]

LGTM thx

I wonder how to reproduce this