Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/chrome_exe.gypi

Issue 7562002: Generate Breakpad symbols for Remoting Host plugin on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix dSYM location, set mac_real_dsym=1 and add chrome dependency. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/build/mac/dump_product_syms » ('j') | chrome/tools/build/mac/dump_product_syms » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 8f0a4814dff61947b1622dac9c0a13f20512634b..2c6f25be493d3a46fd44f81b5e06e05bc4492d8c 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -235,12 +235,17 @@
'dependencies': [
'../breakpad/breakpad.gyp:dump_syms',
'../breakpad/breakpad.gyp:symupload',
+ # In order to process symbols for the Remoting Host plugin,
Mark Mentovai 2011/08/04 17:03:26 Blank line before.
+ # that plugin needs to be built beforehand. Since the
+ # "Dump Symbols" step hangs off this target, that plugin also
+ # needs to be added as a dependency.
+ '../remoting/remoting.gyp:remoting_host_plugin',
],
# The "Dump Symbols" post-build step is in a target_conditions
# block so that it will follow the "Strip If Needed" step if that
# is also being used. There is no standard configuration where
# both of these steps occur together, but Mark likes to use this
- # configuraiton sometimes when testing Breakpad-enabled builds
+ # configuration sometimes when testing Breakpad-enabled builds
# without the time overhead of creating real .dSYM files. When
# both "Dump Symbols" and "Strip If Needed" are present, "Dump
# Symbols" must come second because "Strip If Needed" creates
« no previous file with comments | « no previous file | chrome/tools/build/mac/dump_product_syms » ('j') | chrome/tools/build/mac/dump_product_syms » ('J')

Powered by Google App Engine
This is Rietveld 408576698