Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/chrome_exe.gypi

Issue 7562002: Generate Breakpad symbols for Remoting Host plugin on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix dSYM location, set mac_real_dsym=1 and add chrome dependency. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'variables': { 7 'variables': {
8 'chrome_exe_target': 0, 8 'chrome_exe_target': 0,
9 }, 9 },
10 'target_conditions': [ 10 'target_conditions': [
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 'mac_real_dsym': 1, 228 'mac_real_dsym': 1,
229 }, 229 },
230 'xcode_settings': { 230 'xcode_settings': {
231 # With mac_real_dsym set, strip_from_xcode won't be used. 231 # With mac_real_dsym set, strip_from_xcode won't be used.
232 # Specify CHROMIUM_STRIP_SAVE_FILE directly to Xcode. 232 # Specify CHROMIUM_STRIP_SAVE_FILE directly to Xcode.
233 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)', 233 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
234 }, 234 },
235 'dependencies': [ 235 'dependencies': [
236 '../breakpad/breakpad.gyp:dump_syms', 236 '../breakpad/breakpad.gyp:dump_syms',
237 '../breakpad/breakpad.gyp:symupload', 237 '../breakpad/breakpad.gyp:symupload',
238 # In order to process symbols for the Remoting Host plugin,
Mark Mentovai 2011/08/04 17:03:26 Blank line before.
239 # that plugin needs to be built beforehand. Since the
240 # "Dump Symbols" step hangs off this target, that plugin also
241 # needs to be added as a dependency.
242 '../remoting/remoting.gyp:remoting_host_plugin',
238 ], 243 ],
239 # The "Dump Symbols" post-build step is in a target_conditions 244 # The "Dump Symbols" post-build step is in a target_conditions
240 # block so that it will follow the "Strip If Needed" step if that 245 # block so that it will follow the "Strip If Needed" step if that
241 # is also being used. There is no standard configuration where 246 # is also being used. There is no standard configuration where
242 # both of these steps occur together, but Mark likes to use this 247 # both of these steps occur together, but Mark likes to use this
243 # configuraiton sometimes when testing Breakpad-enabled builds 248 # configuration sometimes when testing Breakpad-enabled builds
244 # without the time overhead of creating real .dSYM files. When 249 # without the time overhead of creating real .dSYM files. When
245 # both "Dump Symbols" and "Strip If Needed" are present, "Dump 250 # both "Dump Symbols" and "Strip If Needed" are present, "Dump
246 # Symbols" must come second because "Strip If Needed" creates 251 # Symbols" must come second because "Strip If Needed" creates
247 # a fake .dSYM that dump_syms needs to fake dump. Since 252 # a fake .dSYM that dump_syms needs to fake dump. Since
248 # "Strip If Needed" is added in a target_conditions block in 253 # "Strip If Needed" is added in a target_conditions block in
249 # common.gypi, "Dump Symbols" needs to be in an (always true) 254 # common.gypi, "Dump Symbols" needs to be in an (always true)
250 # target_conditions block. 255 # target_conditions block.
251 'target_conditions': [ 256 'target_conditions': [
252 ['1 == 1', { 257 ['1 == 1', {
253 'postbuilds': [ 258 'postbuilds': [
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 'configurations': { 495 'configurations': {
491 'Common_Base': { 496 'Common_Base': {
492 'msvs_target_platform': 'x64', 497 'msvs_target_platform': 'x64',
493 }, 498 },
494 }, 499 },
495 }, 500 },
496 ], 501 ],
497 }], 502 }],
498 ], 503 ],
499 } 504 }
OLDNEW
« no previous file with comments | « no previous file | chrome/tools/build/mac/dump_product_syms » ('j') | chrome/tools/build/mac/dump_product_syms » ('J')

Powered by Google App Engine
This is Rietveld 408576698