Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/bug_report_data.h

Issue 7562001: Add memory usage info to SyslogsProvider, and clean up bug report screenshot data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/bug_report_data.cc » ('j') | chrome/browser/bug_report_data.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BUG_REPORT_DATA_H_ 5 #ifndef CHROME_BROWSER_BUG_REPORT_DATA_H_
6 #define CHROME_BROWSER_BUG_REPORT_DATA_H_ 6 #define CHROME_BROWSER_BUG_REPORT_DATA_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/bug_report_util.h"
13 12
14 #if defined(OS_CHROMEOS) 13 #if defined(OS_CHROMEOS)
15 #include "chrome/browser/chromeos/system/syslogs_provider.h" 14 #include "chrome/browser/chromeos/system/syslogs_provider.h"
16 #endif 15 #endif
17 16
17 class Profile;
stevenjb 2011/08/03 01:55:20 forward declaration required with removal of bug_r
18
18 class BugReportData { 19 class BugReportData {
19 public: 20 public:
20 // Make sure we initialize these flags to false since SyslogsComplete
21 // may be triggered before we've called update data; in which case,
22 // we do not want it to just delete the logs it just gathered, and we
23 // don't want it to send the report either - this will make sure that if
24 // SyslogsComplete gets called before UpdateData, we'll simply populate the
25 // sys_info and zip_content fields and exit without disturbing anything else
stevenjb 2011/08/03 01:55:20 Implementation detail comment belongs in C++ file.
26 BugReportData(); 21 BugReportData();
27 ~BugReportData(); 22 ~BugReportData();
28 23
29 // Defined in bug_report_ui.cc
stevenjb 2011/08/03 01:55:20 No longer true.
30 void SendReport(); 24 void SendReport();
31 25
32 void UpdateData(Profile* profile, 26 void UpdateData(Profile* profile,
33 const std::string& target_tab_url, 27 const std::string& target_tab_url,
34 const int problem_type, 28 const int problem_type,
35 const std::string& page_url, 29 const std::string& page_url,
36 const std::string& description, 30 const std::string& description,
37 const std::vector<unsigned char>& image 31 const std::vector<unsigned char>& image
38 #if defined(OS_CHROMEOS) 32 #if defined(OS_CHROMEOS)
39 , const std::string& user_email 33 , const std::string& user_email
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 std::string* zip_content_; 75 std::string* zip_content_;
82 // NOTE: Extra boolean sent_report_ is required because callback may 76 // NOTE: Extra boolean sent_report_ is required because callback may
83 // occur before or after we call SendReport(). 77 // occur before or after we call SendReport().
84 bool sent_report_; 78 bool sent_report_;
85 // Flag to indicate to SyslogsComplete that it should send the report 79 // Flag to indicate to SyslogsComplete that it should send the report
86 bool send_sys_info_; 80 bool send_sys_info_;
87 #endif 81 #endif
88 }; 82 };
89 83
90 #endif // CHROME_BROWSER_BUG_REPORT_DATA_H_ 84 #endif // CHROME_BROWSER_BUG_REPORT_DATA_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bug_report_data.cc » ('j') | chrome/browser/bug_report_data.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698