Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 7558024: Add UMA metrics for blocked plugins. (Closed)

Created:
9 years, 4 months ago by Bernhard Bauer
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Add UMA metrics for blocked plugins. BUG=92170 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96360

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : use viewhostmsg #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M chrome/renderer/blocked_plugin.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/tools/extract_actions.py View 1 2 3 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Bernhard Bauer
please review.
9 years, 4 months ago (2011-08-10 14:53:52 UTC) #1
jochen (gone - plz use gerrit)
http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc#newcode463 chrome/renderer/chrome_content_renderer_client.cc:463: resource, plugin_setting); why not record the UMA here?
9 years, 4 months ago (2011-08-10 15:12:03 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc#newcode463 chrome/renderer/chrome_content_renderer_client.cc:463: resource, plugin_setting); On 2011/08/10 15:12:03, jochen wrote: > why ...
9 years, 4 months ago (2011-08-10 15:16:45 UTC) #3
jochen (gone - plz use gerrit)
On 2011/08/10 15:16:45, Bernhard Bauer wrote: > http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc > File chrome/renderer/chrome_content_renderer_client.cc (right): > > http://codereview.chromium.org/7558024/diff/2001/chrome/renderer/chrome_content_renderer_client.cc#newcode463 ...
9 years, 4 months ago (2011-08-10 15:19:57 UTC) #4
Bernhard Bauer
On 2011/08/10 15:19:57, jochen wrote: > On 2011/08/10 15:16:45, Bernhard Bauer wrote: > > > ...
9 years, 4 months ago (2011-08-10 15:48:20 UTC) #5
jochen (gone - plz use gerrit)
LGTM, thx
9 years, 4 months ago (2011-08-10 15:49:21 UTC) #6
Bernhard Bauer
Forgot to update chromeactions.txt. Take another look?
9 years, 4 months ago (2011-08-10 16:27:00 UTC) #7
jochen (gone - plz use gerrit)
Still LGTM
9 years, 4 months ago (2011-08-10 17:04:22 UTC) #8
commit-bot: I haz the power
9 years, 4 months ago (2011-08-11 11:28:06 UTC) #9
Change committed as 96360

Powered by Google App Engine
This is Rietveld 408576698