Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 7558023: base: Remove a file that is no longer used. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base: Remove a file that is no longer used. Probably since it was added at revision r8. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
D base/no_windows2000_unittest.h View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 4 months ago (2011-08-09 14:45:42 UTC) #1
Evan Martin
9 years, 4 months ago (2011-08-09 15:21:22 UTC) #2
LGTM

On Tue, Aug 9, 2011 at 7:45 AM,  <tfarina@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> base: Remove a file that is no longer used.
>
> Probably since it was added at revision r8.
>
> BUG=None
> TEST=None
>
> R=evan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7558023/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  D base/no_windows2000_unittest.h
>
>
> Index: base/no_windows2000_unittest.h
> diff --git a/base/no_windows2000_unittest.h b/base/no_windows2000_unittest.h
> deleted file mode 100644
> index
>
4aae07df15d03dfce0ec4e6b01462d1420d9042d..0000000000000000000000000000000000000000
> --- a/base/no_windows2000_unittest.h
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -#ifndef BASE_NO_WINDOWS2000_UNITTEST_H_
> -#define BASE_NO_WINDOWS2000_UNITTEST_H_
> -#pragma once
> -
> -#include "testing/gtest/include/gtest/gtest.h"
> -#include "base/win_util.h"
> -
> -// Disable the whole test case when executing on Windows 2000 or lower.
> -// Note: Parent should be testing::Test or UITest.
> -template<typename Parent>
> -class NoWindows2000Test : public Parent {
> - public:
> -  static bool IsTestCaseDisabled() {
> -    return win_util::GetWinVersion() <= win_util::WINVERSION_2000;
> -  }
> -};
> -
> -#endif  // BASE_NO_WINDOWS2000_UNITTEST_H_
>
>
>

Powered by Google App Engine
This is Rietveld 408576698