Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3181)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 7558014: Add a URL param to indicate group selection in Instant field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Passing NULL as far as possible Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index 7661ec1a3f8648997df41c818d6741328c355852..e048c21486ce61a472850e3d66ee87a12db2c7ef 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -891,8 +891,9 @@ TEST_F(TemplateURLServiceTest, ChangeGoogleBaseValue) {
EXPECT_TRUE(model()->GetTemplateURLForHost("google.com") == NULL);
EXPECT_EQ("foo.com", t_url->url()->GetHost());
EXPECT_EQ(ASCIIToUTF16("foo.com"), t_url->keyword());
- EXPECT_EQ("http://foo.com/?q=x", t_url->url()->ReplaceSearchTerms(*t_url,
- ASCIIToUTF16("x"), TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
+ EXPECT_EQ("http://foo.com/?q=x", t_url->url()->ReplaceSearchTerms(NULL,
+ *t_url, ASCIIToUTF16("x"), TemplateURLRef::NO_SUGGESTIONS_AVAILABLE,
+ string16()));
}
struct QueryHistoryCallbackImpl {
@@ -929,8 +930,8 @@ TEST_F(TemplateURLServiceTest, GenerateVisitOnKeyword) {
HistoryService* history =
profile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
history->AddPage(
- GURL(t_url->url()->ReplaceSearchTerms(*t_url, ASCIIToUTF16("blah"), 0,
- string16())),
+ GURL(t_url->url()->ReplaceSearchTerms(NULL, *t_url, ASCIIToUTF16("blah"),
+ 0, string16())),
NULL, 0, GURL(), PageTransition::KEYWORD, history::RedirectList(),
history::SOURCE_BROWSED, false);

Powered by Google App Engine
This is Rietveld 408576698