Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6733)

Unified Diff: chrome/browser/search_engines/search_terms_data.cc

Issue 7558014: Add a URL param to indicate group selection in Instant field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed @pkasting's comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search_engines/search_terms_data.h ('k') | chrome/browser/search_engines/template_url.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/search_terms_data.cc
diff --git a/chrome/browser/search_engines/search_terms_data.cc b/chrome/browser/search_engines/search_terms_data.cc
index 38b0ae2222992d571dc2648746aefe0d5617ee90..3b98b72149367de7d338bba8fe0add728921f694 100644
--- a/chrome/browser/search_engines/search_terms_data.cc
+++ b/chrome/browser/search_engines/search_terms_data.cc
@@ -8,6 +8,7 @@
#include "base/metrics/field_trial.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/google/google_url_tracker.h"
+#include "chrome/browser/instant/instant_field_trial.h"
#include "content/browser/browser_thread.h"
#include "googleurl/src/gurl.h"
@@ -55,10 +56,14 @@ std::string SearchTermsData::GoogleBaseSuggestURLValue() const {
return base_url.ReplaceComponents(repl).spec();
}
+std::string SearchTermsData::InstantFieldTrialUrlParam() const {
+ return std::string();
+}
+
// static
std::string* UIThreadSearchTermsData::google_base_url_ = NULL;
-UIThreadSearchTermsData::UIThreadSearchTermsData() {
+UIThreadSearchTermsData::UIThreadSearchTermsData() : profile_(NULL) {
// GoogleURLTracker::GoogleURL() DCHECKs this also, but adding it here helps
// us catch bad behavior at a more common place in this code.
DCHECK(!BrowserThread::IsWellKnownThread(BrowserThread::UI) ||
@@ -97,6 +102,12 @@ string16 UIThreadSearchTermsData::GetRlzParameterValue() const {
}
#endif
+std::string UIThreadSearchTermsData::InstantFieldTrialUrlParam() const {
+ DCHECK(!BrowserThread::IsWellKnownThread(BrowserThread::UI) ||
+ BrowserThread::CurrentlyOn(BrowserThread::UI));
+ return InstantFieldTrial::GetGroupAsUrlParam(profile_);
+}
+
// static
void UIThreadSearchTermsData::SetGoogleBaseURL(std::string* google_base_url) {
delete google_base_url_;
« no previous file with comments | « chrome/browser/search_engines/search_terms_data.h ('k') | chrome/browser/search_engines/template_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698