Profiles: Bookmark notifications should listen to only a specific profile.

Profiles: Bookmark notifications should listen to only a specific profile.

BUG=87457
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96049

[Elliot Glaysher, 2011-08-08 18:29:54]

jar: metrics service change just changes a name for semantics to show that this
instance has been checked and is OK to listen for all contexts.

pkasting: all else

[Peter Kasting, 2011-08-08 18:47:36]

LGTM

http://codereview.chromium.org/7558003/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_bookmarks_module.cc (right):

http://codereview.chromium.org/7558003/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_bookmarks_module.cc:116: DCHECK_EQ(type,
chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED);
Nit: (expected, actual) (2 places)

http://codereview.chromium.org/7558003/diff/1/chrome/browser/ui/bookmarks/boo...
File chrome/browser/ui/bookmarks/bookmark_tab_helper.cc (right):

http://codereview.chromium.org/7558003/diff/1/chrome/browser/ui/bookmarks/boo...
chrome/browser/ui/bookmarks/bookmark_tab_helper.cc:30:
Source<Profile>(tab_contents->profile()));
Nit: Could maybe save a line by factoring this subexpression into a temp
|source|

[jar (doing other things), 2011-08-09 17:12:13]

Changes in metrics_services LGTM

[commit-bot: I haz the power, 2011-08-09 20:21:31]

Change committed as 96049