Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7555003: Update the .pak file format to version 2: Make resource ids 16bit (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update the .pak file format to version 2: Make resource ids 16bit values instead of 32bit values. On gzip compressed locales files, this saves 17k total. Bump the cached theme pak version so the caches get rebuilt. BUG=76285 TEST=Covered by unit tests and manually tested installing themes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95487

Patch Set 1 #

Total comments: 5

Patch Set 2 : evan's review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M chrome/browser/themes/browser_theme_pack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download
M tools/data_pack/data_pack.py View 1 4 chunks +7 lines, -6 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/grit/grit/format/data_pack_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/resource/data_pack.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/resource/data_pack.cc View 7 chunks +22 lines, -22 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/test/data/data_pack_unittest/sample.pak View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
The gfx_unittest failures are a lie. The changes to sample.pak didn't get applied because it's ...
9 years, 4 months ago (2011-08-03 18:36:04 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/7555003/diff/1/chrome/browser/themes/browser_theme_pack.cc File chrome/browser/themes/browser_theme_pack.cc (right): http://codereview.chromium.org/7555003/diff/1/chrome/browser/themes/browser_theme_pack.cc#newcode35 chrome/browser/themes/browser_theme_pack.cc:35: // int32_t. kHeaderID should always have the maximum ...
9 years, 4 months ago (2011-08-03 18:43:09 UTC) #2
tony
Elliot, did you want to take a quick look? http://codereview.chromium.org/7555003/diff/1/chrome/browser/themes/browser_theme_pack.cc File chrome/browser/themes/browser_theme_pack.cc (right): http://codereview.chromium.org/7555003/diff/1/chrome/browser/themes/browser_theme_pack.cc#newcode35 chrome/browser/themes/browser_theme_pack.cc:35: ...
9 years, 4 months ago (2011-08-04 17:42:53 UTC) #3
Elliot Glaysher
9 years, 4 months ago (2011-08-04 17:52:50 UTC) #4
LGTM (just did a quick pass; nothing in depth. thank you for remembering to
update theme pack version number.)

Powered by Google App Engine
This is Rietveld 408576698