Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 7554008: Removal of Profile from content part 6. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 4 months ago
Reviewers:
Miranda Callahan, jam
CC:
chromium-reviews, asanka, vrk (LEFT CHROMIUM), acolwell+watch_chromium.org, mihaip+watch_chromium.org, ajwong+watch_chromium.org, dhollowa, GeorgeY, Erik does not do reviews, joi+watch-content_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Randy Smith (Not in Mondays), annacc+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, tfarina, Aaron Boodman, eroman, estade+watch_chromium.org, mmenke
Visibility:
Public.

Description

Removal of Profile from content part 6. The concept of some WebUIs not being based on TabContents lived for two weeks (added r62478, removed r63713) but this support code was never removed. BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96390

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : Profile helper function, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -217 lines) Patch
M chrome/browser/chromeos/accessibility_util.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 3 4 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 4 3 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bug_report_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/history2_ui.cc View 1 2 3 4 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 3 4 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals_ui.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 2 3 4 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 2 3 4 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 2 3 4 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/shown_sections_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 1 2 3 4 9 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 4 11 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 3 4 7 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/stop_syncing_handler.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 4 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/webui/web_ui.cc View 4 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
9 years, 4 months ago (2011-08-04 18:05:13 UTC) #1
jam
lgtm what do you think of having a convenience function like Profile::FromWebUI? http://codereview.chromium.org/7554008/diff/8001/chrome/browser/ui/webui/history_ui.cc File chrome/browser/ui/webui/history_ui.cc ...
9 years, 4 months ago (2011-08-09 16:11:19 UTC) #2
Avi (use Gerrit)
Feels weird to me a bit, that Profile would know about WebUI explicitly. You don't ...
9 years, 4 months ago (2011-08-09 16:17:17 UTC) #3
jam
On 2011/08/09 16:17:17, Avi wrote: > Feels weird to me a bit, that Profile would ...
9 years, 4 months ago (2011-08-09 20:22:57 UTC) #4
Avi (use Gerrit)
Miranda's OK with it, so I made the change. I'm doing a build but will ...
9 years, 4 months ago (2011-08-09 20:25:31 UTC) #5
Avi (use Gerrit)
done; ptal
9 years, 4 months ago (2011-08-09 22:09:06 UTC) #6
jam
lgtm
9 years, 4 months ago (2011-08-10 02:50:21 UTC) #7
Avi (use Gerrit)
Miranda, need a profile owner.
9 years, 4 months ago (2011-08-10 17:44:54 UTC) #8
Miranda Callahan
9 years, 4 months ago (2011-08-10 19:17:52 UTC) #9
On 2011/08/10 17:44:54, Avi wrote:
> Miranda, need a profile owner.

LGTM

Powered by Google App Engine
This is Rietveld 408576698