Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 7554007: Merge r8774 from bleeding edge to 3.4 branch. (Closed)

Created:
9 years, 4 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge r8774 from bleeding edge to 3.4 branch. Check for phi-uses of arguments object before eliminating dead phi's. HGraphBuilder::TryArgumentsAccess does not emit any uses for receiver and will generate incorrect code when receiver for a property access is defined by a phi that returns either arguments object or something else. BUG=v8:1582 TEST=test/mjsunit/regress/regress-1582.js Committed: http://code.google.com/p/v8/source/detail?r=8775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/hydrogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-1582.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 4 months ago (2011-08-02 10:41:07 UTC) #1
Kevin Millikin (Chromium)
9 years, 4 months ago (2011-08-02 10:45:01 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698