Enable/disable input methods according to |text_input_type_| when a view

Enable/disable input methods according to |text_input_type_| when a view
is selected so that input methods don't eat keyboard shortcuts.

BUG=80772
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96149

[bashi, 2011-08-02 09:35:58]

Hi,

I'd be grateful if you could take a look at this CL.

Regards,

[bashi, 2011-08-02 11:00:57]

(Forgot to set reviewers)

Again, could you take a look at this CL?

Regards,

[James Su, 2011-08-08 01:41:09]

http://codereview.chromium.org/7554005/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7554005/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_win.cc:290: if
(text_input_type_ == ui::TEXT_INPUT_TYPE_TEXT)
Several additional text input type have been added. So this check should be
changed accordingly. See RenderWidgetHostViewWin::ImeUpdateTextInputState() for
reference.

[bashi, 2011-08-08 06:16:27]

Hi James,

Thank you for review.  Addressed your comment.

http://codereview.chromium.org/7554005/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7554005/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_win.cc:290: if
(text_input_type_ == ui::TEXT_INPUT_TYPE_TEXT)
On 2011/08/08 01:41:11, James Su wrote:
> Several additional text input type have been added. So this check should be
> changed accordingly. See RenderWidgetHostViewWin::ImeUpdateTextInputState()
for
> reference.

Done.

[James Su, 2011-08-08 06:21:51]

LGTM

[commit-bot: I haz the power, 2011-08-09 06:27:49]

Try job failure for 7554005-5001 (retry) (previous was lost) on mac for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2011-08-10 05:05:46]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 96124, job name
was 7554005-5001 (retry) (previous was lost) (previous was lost) (retry).

[commit-bot: I haz the power, 2011-08-10 08:14:05]

Change committed as 96149