Issue 7554001: multi-profiles: button strip ordering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7554001: multi-profiles: button strip ordering (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
James Hawkins, jhawkins, binji

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

multi-profiles: button strip ordering BUG=none TEST=order of buttons should be correct for profile management ui Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95464

Patch Set 2 : other one fixed too #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/manage_profile_overlay.html	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

binji

http://codereview.chromium.org/7554001/diff/1/chrome/browser/resources/options/manage_profile_overlay.html File chrome/browser/resources/options/manage_profile_overlay.html (right): http://codereview.chromium.org/7554001/diff/1/chrome/browser/resources/options/manage_profile_overlay.html#newcode33 chrome/browser/resources/options/manage_profile_overlay.html:33: <button id="delete-profile-ok" Fix this one too.

9 years, 4 months ago (2011-08-02 20:00:55 UTC) #2

Evan Stade

james, as a committer can you lg this -- Evan Stade On Wed, Aug 3, ...

9 years, 4 months ago (2011-08-03 23:25:12 UTC) #4

LGTM

Expand Messages | Collapse Messages

Issue 7554001: multi-profiles: button strip ordering (Closed)

Description

Patch Set 1 #

Patch Set 2 : other one fixed too #

Messages