Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef PPAPI_CPP_MODULE_EMBEDDER_H_ | 5 #ifndef PPAPI_CPP_MODULE_EMBEDDER_H_ |
| 6 #define PPAPI_CPP_MODULE_EMBEDDER_H_ | 6 #define PPAPI_CPP_MODULE_EMBEDDER_H_ |
| 7 | 7 |
| 8 /// @file | |
| 9 /// This file defines the APIs for creating a Module object. | |
| 8 namespace pp { | 10 namespace pp { |
| 9 | 11 |
| 12 /// A Module object associated with this module. | |
|
dmichael (off chromium)
2011/08/03 15:50:49
Just remove this comment.
jond
2011/08/04 19:55:20
Done.
| |
| 10 class Module; | 13 class Module; |
|
dmichael (off chromium)
2011/08/03 15:50:49
Please add a carriage return here.
jond
2011/08/03 20:15:08
Done.
jond
2011/08/04 19:55:20
Done.
| |
| 11 // Implemented by the embedder. | 14 /// This function creates the <code>pp::Module</code> object associated with |
| 12 // | 15 /// this module. |
| 13 // Creates the pp::Module object associated with this plugin. Returns the | 16 /// |
| 14 // module if it was successfully created, or NULL on failure. Upon failure, | 17 /// @return Returns the module if it was successfully created, or NULL on |
| 15 // the plugin will be unloaded. | 18 /// failure. Upon failure, the module will be unloaded. |
| 19 /// | |
| 20 // <strong>Note:</code> This method documentation had "implemented by the | |
| 21 // embedder" at the top. not sure what that means. | |
|
dmichael (off chromium)
2011/08/03 15:50:49
It means that the developer of the plugin/NaCl mod
jond
2011/08/03 20:15:08
So, do I need this note or will people learn this
dmichael (off chromium)
2011/08/04 16:33:38
Yes, the API needs to be documented here. The exam
jond
2011/08/04 19:55:20
Done.
jond
2011/08/04 19:55:20
Done.
| |
| 16 pp::Module* CreateModule(); | 22 pp::Module* CreateModule(); |
| 17 | 23 |
| 18 } // namespace pp | 24 } // namespace pp |
| 19 | 25 |
| 20 #endif // PPAPI_CPP_MODULE_EMBEDDER_H_ | 26 #endif // PPAPI_CPP_MODULE_EMBEDDER_H_ |
| OLD | NEW |