Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 7553025: Remove obsolete use of CLIPPED_HISTOGRMAS (Closed)

Created:
9 years, 4 months ago by jar (doing other things)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove obsolete use of CLIPPED_HISTOGRMAS Histograms that "clip" data (discard samples over a given point) make it hard or impossible to contrast results (such as via trimmed means). As a result, a long standing note asked that these histogram form no longer be used. This CL removes all remaining uses, and discards so histograms that are no longer significant (to SDCH experimentation). We transition to CUSTOM_HISTOGRAMS for all cases where the data appears to be useful (and we provide new names for the histograms). r=rtenneti,wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95570

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -137 lines) Patch
M net/http/http_network_transaction.cc View 1 5 chunks +24 lines, -25 lines 0 comments Download
M net/url_request/url_request_http_job.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 3 chunks +3 lines, -105 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jar (doing other things)
To drop in the subtle calls in histogram.h, I first decided I should clean up ...
9 years, 4 months ago (2011-08-02 22:46:21 UTC) #1
jar (doing other things)
Raman, This is a pretty straight forward CL, and Will is probably on vacation. Could ...
9 years, 4 months ago (2011-08-04 19:15:30 UTC) #2
ramant (doing other things)
LGTM. thanks, raman
9 years, 4 months ago (2011-08-04 20:28:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 7553025-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-05 00:31:12 UTC) #4
jar (doing other things)
wtc, I need a review from a net/* owner. The change is all focused on ...
9 years, 4 months ago (2011-08-05 01:12:04 UTC) #5
wtc
LGTM.
9 years, 4 months ago (2011-08-05 01:28:34 UTC) #6
commit-bot: I haz the power
9 years, 4 months ago (2011-08-05 04:04:36 UTC) #7
Change committed as 95570

Powered by Google App Engine
This is Rietveld 408576698