Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 7553018: Resolve to temporary texture when doing readpixels (Closed)

Created:
9 years, 4 months ago by jbauman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Resolve to temporary texture when doing readpixels We don't want to resolve to the parent texture, as that can cause an accidental swapbuffers when preserveDrawingBuffer is false. Instead create a temporary texture which will stick around for a while. BUG=55927 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 13 chunks +60 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbauman
9 years, 4 months ago (2011-08-02 21:58:55 UTC) #1
Ken Russell (switch to Gerrit)
LGTM It would be nice if we could avoid resolving the entire framebuffer for the ...
9 years, 4 months ago (2011-08-02 22:14:43 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-03 21:54:29 UTC) #3
Change committed as 95332

Powered by Google App Engine
This is Rietveld 408576698