Add some browser tests for net-internals

chrome/browser/resources/net_internals/browser_bridge.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This class provides a "bridge" for communicating between the javascript and
  * the browser.
  */
 
 var BrowserBridge = (function() {
@@ skipping 48 matching lines @@
                                this.sendGetPrerenderInfo.bind(this));
 
     // NetLog entries are all sent to the |SourceTracker|, which both tracks
     // them and manages its own observer list.
     this.sourceTracker = new SourceTracker();
 
     // Setting this to true will cause messages from the browser to be ignored,
     // and no messages will be sent to the browser, either.  Intended for use
     // when viewing log files.
     this.disabled_ = false;
+
+    // Interval id returned by window.setInterval for polling timer.
+    this.pollIntervalId_ = null;
   }
 
   cr.addSingletonGetter(BrowserBridge);
 
   BrowserBridge.prototype = {
 
     //--------------------------------------------------------------------------
     // Messages sent to the browser
     //--------------------------------------------------------------------------
 
     /**
      * Wraps |chrome.send|.  Doesn't send anything when disabled.
      */
     send: function(value1, value2) {
       if (!this.disabled_) {
         if (arguments.length == 1) {
           chrome.send(value1);
         } else if (arguments.length == 2) {
           chrome.send(value1, value2);
         } else {
           throw 'Unsupported number of arguments.';
         }
       }
     },
 
     sendReady: function() {
       this.send('notifyReady');
+      this.setPollInterval(POLL_INTERVAL_MS);
+    },
 
-      // Some of the data we are interested is not currently exposed as a
-      // stream, so we will poll the browser to find out when it changes and
-      // then notify the observers.
-      window.setInterval(this.checkForUpdatedInfo.bind(this, false),
-                         POLL_INTERVAL_MS);
+    /**
+     * Some of the data we are interested is not currently exposed as a
+     * stream.  This starts polling those with active observers (visible
+     * views) every |intervalMs|.  Subsequent calls override previous calls
+     * to this function.  If |intervalMs| is 0, stops polling.  Function only
+     * exposed for unit testing.
+     */
+    setPollInterval: function(intervalMs) {
+      if (this.pollIntervalId_ !== null) {
+        window.clearInterval(this.pollIntervalId_);
+        this.pollIntervalId_ = null;
+      }
+
+      if (intervalMs > 0) {
+        this.pollIntervalId_ =
+            window.setInterval(this.checkForUpdatedInfo.bind(this, false),
+                               intervalMs);
+      }
     },
 
     sendGetProxySettings: function() {
       // The browser will call receivedProxySettings on completion.
       this.send('getProxySettings');
     },
 
     sendReloadProxySettings: function() {
       this.send('reloadProxySettings');
     },
@@ skipping 189 matching lines @@
     receivedPrerenderInfo: function(prerenderInfo) {
       this.pollableDataHelpers_.prerenderInfo.update(prerenderInfo);
     },
 
     //--------------------------------------------------------------------------
 
     /**
      * Prevents receiving/sending events to/from the browser.
      */
     disable: function() {
       this.disabled_ = true;

[eroman, 2011/08/03 00:32:24]

it might be a good idea to clear the polling interval here as well:

this.setPollingInterval(0);


(in which case should remove the comment that it is only for testing).

[mmenke, 2011/08/03 15:44:17]

Good idea, done.

     },
 
     /**
      * Adds a listener of the proxy settings. |observer| will be called back
      * when data is received, through:
      *
      *   observer.onProxySettingsChanged(proxySettings)
      *
      * |proxySettings| is a dictionary with (up to) two properties:
      *
@@ skipping 301 matching lines @@
       helper.removeObserver(this);
       --this.observingCount_;
       this.updatedData_[name] = data;
       if (this.observingCount_ == 0)
         this.callback_(this.updatedData_);
     }
   };
 
   return BrowserBridge;
 })();